[INLONG-11013][Sort] A demo of reporting sort logs through OpenTelemetry #11015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloyszhang
reviewed
Sep 6, 2024
| <dependency> | ||
| <groupId>io.opentelemetry.instrumentation</groupId> | ||
| <artifactId>opentelemetry-instrumentation-api</artifactId> | ||
| <version>1.28.0</version> |
There was a problem hiding this comment.
I found a better way to do this at #11065 .
aloyszhang
reviewed
Sep 6, 2024
| <dependency> | ||
| <groupId>io.opentelemetry.instrumentation</groupId> | ||
| <artifactId>opentelemetry-log4j-appender-2.17</artifactId> | ||
| <version>1.28.0-alpha</version> |
aloyszhang
reviewed
Sep 6, 2024
| <dependency> | ||
| <groupId>io.opentelemetry</groupId> | ||
| <artifactId>opentelemetry-semconv</artifactId> | ||
| <version>1.28.0-alpha</version> |
aloyszhang
reviewed
Sep 6, 2024
| <dependency> | ||
| <groupId>io.opentelemetry</groupId> | ||
| <artifactId>opentelemetry-sdk-logs</artifactId> | ||
| <version>1.28.0</version> |
aloyszhang
reviewed
Sep 6, 2024
| <dependency> | ||
| <groupId>com.squareup.okio</groupId> | ||
| <artifactId>okio</artifactId> | ||
| <version>1.17.2</version> |
aloyszhang
reviewed
Sep 6, 2024
| @@ -88,6 +95,7 @@ public class MySqlSourceReader<T> | |||
| private final MySqlSourceReaderContext mySqlSourceReaderContext; | |||
| private MySqlBinlogSplit suspendedBinlogSplit; | |||
| private final DebeziumDeserializationSchema<T> metricSchema; | |||
| private OpenTelemetrySdk SDK; | |||
There was a problem hiding this comment.
Better to add a configuration to enable or disable opentelemetry
There was a problem hiding this comment.
I found a better way to do this at #11065 .
|
@qy-liuhuo do we still need to keep this pull request open? |
As there is a new solution, this PR should be closed. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11013
Motivation
Modifications
Implement the demo of uploading mysql-connector logs to opentelemetry-collector
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows: